Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add systemd support and puma 5 support #300

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Conversation

ayamomiji
Copy link
Contributor

Fix #297
Tested with generated puma.rb
Tested with puma 4 and 5 with rvm and rbenv

@S3od22
Copy link

S3od22 commented Oct 19, 2020

ا

@seuros seuros merged commit 5e3b949 into seuros:master Nov 2, 2020
@seuros
Copy link
Owner

seuros commented Nov 2, 2020

@S3od22 @ayamomiji , i pushed a new version that dont create another namespace for the start/stop tasks.
Can you tell me your feedback.

Also @ayamomiji , how did you fix the $HOME in the systemd service ? SystemD require an absolute path.

@attenzione
Copy link

@seuros +1 for same namespace for tasks and extraction of daemon plugin.
I've left few comments in your commit, please review them ;)

@seuros
Copy link
Owner

seuros commented Nov 3, 2020

thank you @attenzione .

@attenzione
Copy link

Have you seen another comment? 24b91a7#r43833430
Seems this will be an issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Puma 5.0
4 participants