Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cmake] Use dlib::dlib_shared for target_link_libraries #22

Closed
wants to merge 1 commit into from

Conversation

takotakot
Copy link

This PR allows us to avoid "CMake Warning" that 'dlib_INCLUDE_DIRS' and 'dlib_LIBRARIES' are deplicated. With this request, #21 is solved.

According to davisking, dlib owner, "If you changed libgazr's target_link_libraries call to link against dlib::dlib_shared it works." ref: davisking/dlib#1073 .

When I run cmake .. I found below warings:

CMake Warning at ... dlib/dlibConfig.cmake:42 (message):
  The variable 'dlib_INCLUDE_DIRS' is deprecated! Instead, simply use
  target_link_libraries(your_app dlib::dlib).  See
  http://dlib.net/examples/CMakeLists.txt.html for an example.
Call Stack (most recent call first):
  CMakeLists.txt:9999 (__deprecated_var)

CMake Warning at ... dlib/dlibConfig.cmake:42 (message):
  The variable 'dlib_LIBRARIES' is deprecated! Instead, simply use
  target_link_libraries(your_app dlib::dlib).  See
  http://dlib.net/examples/CMakeLists.txt.html for an example.
Call Stack (most recent call first):
  CMakeLists.txt:9999 (__deprecated_var)

. For this project dlib::dlib_shared seems better than dlib::dlib.

Avoid "CMake Warning" that 'dlib_INCLUDE_DIRS' and 'dlib_LIBRARIES' are deplicated.
@severin-lemaignan
Copy link
Owner

Closed in #28

@severin-lemaignan
Copy link
Owner

It doesn't seem that dlib is exporting a dlib::dlib_shared anymore? (tried with dlib-19.22). So simply linking with dlib::dlib.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants