Add PkeyCtx::new_from_name
#2051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
force-pushed
the
add-pkey-ctx
branch
from
46509a9 to
8241c76
Compare
sfackler
reviewed
Oct 14, 2023
| pub fn new_from_name( | ||
| lib_ctx: &crate::lib_ctx::LibCtxRef, | ||
| name: &str, | ||
| property: Option<&str>, |
There was a problem hiding this comment.
I don't think this is sound:
None of the arguments are duplicated, so they must remain unchanged for the lifetime of the returned EVP_PKEY_CTX or of any of its duplicates.
|
Sadly, due to resource-constraints I won't be able to continue working on this so closing. Thanks for your time! 👋 |
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Feb 14, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA and ECDSA keys using the new API in tests. It does not expose all possible API that are available as I did not have a good way to test the unused API yet. I do not know if this API is available in some other *SSL libraries right now so for now all of the additions are marked with #[cfg(ossl300)]. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Feb 14, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA and ECDSA keys using the new API in tests. It does not expose all possible API that are available as I did not have a good way to test the unused API yet. I do not know if this API is available in some other *SSL libraries right now so for now all of the additions are marked with #[cfg(ossl300)]. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Feb 14, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA and ECDSA keys using the new API in tests. It does not expose all possible API that are available as I did not have a good way to test the unused API yet. I do not know if this API is available in some other *SSL libraries right now so for now all of the additions are marked with #[cfg(ossl300)]. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Feb 27, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA and ECDSA keys using the new API in tests. It does not expose all possible API that are available as I did not have a good way to test the unused API yet. I do not know if this API is available in some other *SSL libraries right now so for now all of the additions are marked with #[cfg(ossl300)]. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Feb 28, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA and ECDSA keys using the new API in tests. It does not expose all possible API that are available as I did not have a good way to test the unused API yet. I do not know if this API is available in some other *SSL libraries right now so for now all of the additions are marked with #[cfg(ossl300)]. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Feb 28, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA and ECDSA keys using the new API in tests. It does not expose all possible API that are available as I did not have a good way to test the unused API yet. I do not know if this API is available in some other *SSL libraries right now so for now all of the additions are marked with #[cfg(ossl300)]. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Mar 5, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA keys using the new API. It does not expose OSSL_PARAM API as that is considered fragile. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Mar 5, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA keys using the new API. It does not expose OSSL_PARAM API as that is considered fragile. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Mar 5, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA keys using the new API. It does not expose OSSL_PARAM API as that is considered fragile. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Mar 6, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA keys using the new API. It does not expose OSSL_PARAM API as that is considered fragile. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Mar 13, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA keys using the new API. It does not expose OSSL_PARAM API as that is considered fragile. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047 Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Jakuje
added a commit
to Jakuje/rust-openssl
that referenced
this pull request
Mar 13, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is now mostly PoC on using RSA keys using the new API. It does not expose OSSL_PARAM API as that is considered fragile. This is partially based on sfackler#2051 which was abandoned. Fixes: sfackler#2047 Signed-off-by: Jakub Jelen <jjelen@redhat.com>
teythoon
pushed a commit
to teythoon/rust-openssl
that referenced
this pull request
May 12, 2025
The OpenSSL 3.* users now do not have a way to use non-deprecated API by using this rust bindings, which is not sustainable in the long term as either distributions will stop building with the deprecated API or it will be eventually removed. This is partially based on sfackler#2051 which was abandoned. Signed-off-by: Jakub Jelen <jjelen@redhat.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR will eventually close #2047 but I'm submitting a work-in-process so that I can see CI failures. (I hope you don't mind!)