Remove warning about unspecified vkbinding #6085
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is permitted that users omit explicit [vk::binding] settings on HLSL-style register definitions. They are just opting into the default implicit mapping, as they would with HLSL->VK in DXC. That does mean register IDs can clash between resources which have different register type but the same register number. Such a problem can be resolved either with explicit bindings ([vk::binding]) in source, or using the "-fvk-binding" slangc options which match DXC behavior. Closes issue shader-slang#5938
cheneym2
force-pushed
the
acheney/bindingwarning2
branch
from
31f8eaa to
90f8d03
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
csyonghe
reviewed
Jan 14, 2025
| { | ||
| // If we warn due to invalid bindings and user did not set how to interpret 'hlsl style | ||
| // bindings', we should map `register` 1:1 with equivlent vulkan bindings. | ||
| // If the user did not set how to interpret 'hlsl style bindings', we should map |
There was a problem hiding this comment.
Instead of removing the warning completely, let's remove the warning only if hlslToVulkanLayoutOptions is not set or hlslToVulkanLayoutOptions->canInfer(vulkanKind, hlslInfo.space) is false, and amend the warning message to ask the user to either use [vk::binding] or specify -fvk-binding- options.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is permitted that users omit explicit [vk::binding] settings on register definitions of HLSL-style, as they are opting into the default implicit mapping, as with DXC.
That does mean register IDs can clash between resources which have different register type but the same register number. For example:
Such a
problem can be resolved either with explicit bindings in source, or using the "-fvk-binding" slangc options which match DXC behavior.
Closes issue #5938