Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EME logger broke booking.com's pop-up window #25

Closed
xhwang-chromium opened this issue Nov 15, 2021 · 2 comments
Closed

EME logger broke booking.com's pop-up window #25

xhwang-chromium opened this issue Nov 15, 2021 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@xhwang-chromium
Copy link
Contributor

It seems the latest EME logger (version 3.1.1) broke booking.com's pop-up window.

Steps to repro:

  • Has EME logger (version 3.1.1) extension enabled
  • Go to booking.com
  • Search for a hotel and click a result
  • Click the "Show on map" on the left panel

Expected:

  • Map shows up in a pop-up window

Actual:

  • Map never shows up.

Note:

  • The problem goes away after disabling EME logger.
  • This can also be reproduced by clicking a room to see details. The pop up window keeps spinning (see attached screenshot).
@xhwang-chromium
Copy link
Contributor Author

booking

@joeyparrish joeyparrish self-assigned this Nov 15, 2021
@joeyparrish
Copy link
Member

This line at the end of TraceAnything is responsible:

exports = {TraceAnything};

This bug was introduced when we forked TraceAnything into its own module.

If I open the debugger and set a breakpoint on that line, then skip over it and set exports back to undefined, booking.com works correctly. It looks like I accidentally polluted the window from the module and broke another module system by writing to global exports.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Nov 15, 2021
joeyparrish added a commit to joeyparrish/eme_logger that referenced this issue Nov 15, 2021
Updates TraceAnything engine to fix window pollution that broke booking.com and probably countless other sites

Closes shaka-project#25
shaka-bot pushed a commit that referenced this issue Nov 15, 2021
Updates TraceAnything engine to fix window pollution that broke booking.com and probably countless other sites

Closes #25

Change-Id: I6d2299fb4357888b72033c575831854e50dd267b
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Feb 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants