Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No equivalent 3-letter language code #1457

Closed
atadzan opened this issue Dec 11, 2024 · 2 comments · Fixed by #1458 or #1463
Closed

No equivalent 3-letter language code #1457

atadzan opened this issue Dec 11, 2024 · 2 comments · Fixed by #1458 or #1463
Labels
status: archived Archived and locked; will not be updated

Comments

@atadzan
Copy link

atadzan commented Dec 11, 2024

System info

Operating System: Docker image alpine:3.18
Shaka Packager Version: v3.3.0

Issue and steps to reproduce the problem

Packager Command:

/usr/local/bin/packager in=tmp/35ad6424-23c5-4a00-a2a9-c39c41bb0aa1.mp4,stream=1,segment_template=tmp/audio/iw/$Number$.aac,playlist_name=tmp/audio/iw/audio.m3u8,hls_group_id=audio,hls_name=,language=iw in=tmp/d483d2b0-635c-438e-8b65-2ccb35931585.mp4,stream=video,segment_template=tmp/480p/$Number$.ts,playlist_name=tmp/480p/playlist.m3u8 --segment_duration 4 --default_language iw --hls_master_playlist_output tmp/master.m3u8

Extra steps to reproduce the problem?
(1) Download this video from youtube with default audio track
(2) Then try to transcode it with shaka-packager

What is the expected result?
It is expected to be successfully transcoded
What happens instead?
It throws error like below

packager_main.cc:624] Failed to initialize packager: 3 (INVALID_ARGUMENT): Unknown/invalid language specified: iw |  
language_utils.cc:136] No equivalent 3-letter language code for iw

I need help, please. Thanks in advance

@joeyparrish
Copy link
Member

MP4s contain language metadata using 3-letter language codes only, so we map 2-letter codes to 3-letter codes to make this work. It looks like our 2-letter-to-3-letter language code map is missing an entry.

The 3-letter code for Hebrew is "heb", so "iw" should map to "heb".

@joeyparrish
Copy link
Member

I see "heb" mapped to "he", but not to the alternate 2-letter code "iw".

https://github.com/shaka-project/shaka-packager/blob/a26e6623d694fa4ca592e0b4594a01e4c23aa291/packager/media/base/language_utils.cc

joeyparrish added a commit that referenced this issue Dec 12, 2024
We already mapped Hebrew's "heb" to "he", but not to the alternative 2-letter code "iw".

Closes #1457
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Feb 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
2 participants