Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[HLS] Ad Cues is not handled correctly in iFrames only playlists #396

Closed
kqyang opened this issue May 16, 2018 · 0 comments
Closed

[HLS] Ad Cues is not handled correctly in iFrames only playlists #396

kqyang opened this issue May 16, 2018 · 0 comments
Assignees
@kqyang
Labels
component: HLS The issue involves HLS output status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1

Comments

@kqyang
Copy link
Contributor

kqyang commented May 16, 2018

See https://widevine-internal-review.googlesource.com/c/packager/+/50381/3/packager/app/test/testdata/hls-audio-video-text-with-ad-cues/bear-640x360-video-iframe.m3u8#11.

EXT-X-PLACEMENT-OPPORTUNITY is inserted in the wrong position.

 #EXT-X-PLAYLIST-TYPE:VOD
 #EXT-X-I-FRAMES-ONLY
 #EXT-X-MAP:URI="bear-640x360-video-init.mp4"
 #EXTINF:1.001,
 #EXT-X-BYTERANGE:15581@80
 bear-640x360-video-1.m4s
-#EXT-X-PLACEMENT-OPPORTUNITY
 #EXTINF:1.001,
 #EXT-X-BYTERANGE:18221@80
 bear-640x360-video-2.m4s
+#EXT-X-PLACEMENT-OPPORTUNITY
 #EXTINF:0.734,
 #EXT-X-BYTERANGE:19663@80
 bear-640x360-video-3.m4s
@kqyang kqyang added component: HLS The issue involves HLS output type: bug Something isn't working correctly labels May 16, 2018
@kqyang kqyang added this to the v2.1 milestone May 16, 2018
shaka-bot pushed a commit that referenced this issue May 23, 2018
@kqyang
[HLS] Fixing AdCues handling in iframe playlists
cf40acc 
Previously for the last iframe in a segment, we wait for the next
segment to arrive before writing the EXTINF tag. If an Ad Cue comes
in before the next segment, the EXT-X-PLACEMENT_OPPORTUNITY tag would
be inserted before the iframe in previous segment.

Fixes #378, #396.

Change-Id: I1ede72a4d4edca94781c7b05bc25397d67916d1a
@kqyang kqyang closed this as completed May 23, 2018
@kqyang kqyang self-assigned this May 23, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 22, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Jul 22, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@kqyang kqyang

Labels
component: HLS The issue involves HLS output status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
2 participants
@kqyang @shaka-bot