Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Fix missing graphviz outputs in generated docs #1392

Merged
merged 1 commit into from
May 1, 2024

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented May 1, 2024

Fixes #1388

@cosmin
Copy link
Contributor Author

cosmin commented May 1, 2024

@joeyparrish I believe this should fix the graphviz documentation but I'm not seeing a good way to test workflow action since it only seems to run upon release.

@cosmin cosmin requested a review from joeyparrish May 1, 2024 05:18
@cosmin cosmin changed the title install graphviz as part of build-docs chore: install graphviz as part of build-docs May 1, 2024
@cosmin cosmin added this to the v3.1 milestone May 1, 2024
@joeyparrish
Copy link
Member

It looks like build-docs runs on PRs, too, and attaches the output as an artifact to the CI run.

See https://github.com/shaka-project/shaka-packager/actions/runs/8905726332/artifacts/1463047996

I opened that archive and found that the graphs are restored, so this PR works.

@joeyparrish joeyparrish changed the title chore: install graphviz as part of build-docs docs: Fix missing graphviz outputs in generated docs May 1, 2024
@joeyparrish joeyparrish merged commit 62f861c into shaka-project:main May 1, 2024
37 of 38 checks passed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shaka packager de# document
2 participants