Issue 214 #215
Merged
Issue 214 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue could lead to the MPD attribute mediaPresentationDuration being wrongly generated for WebM streams with a duration longer than INT32_MAX. The root-cause was that StreamInfo::set_duration() accepted an int instead of a uint64_t. This seems like a pure typo, since StreamInfo already uses a uint64_t internally for representing duration.
github-actions
bot
added
the
status: archived
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix issue #214 where it was possible for StreamInfo::set_duration() to overflow, potentially causing the mediaPresentationDuration attribute in the <MPD> tag to become corrupted/wrong.