Fix Windows shared_library builds #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make shared_library builds work on Windows with MSVS 2019, this commit: - Silences a useless warning about a private member in dll-exported Status class. - Exports the File class used by packager.exe - Removes the explicit File dependency in packager.exe in favor of libpackager, now that File is exported - Add missing defines in packager.exe and packager_test.exe that instruct the linker to import Status and File from the library Closes #318 (shared_library builds on Windows) Issue #336 (progress toward GitHub Actions workflow to replace Travis and Appveyor, where we need to build and test shared_library on all platforms) b/190743862 (internal; tracking replacement of Travis) Change-Id: I091f1655d88d36f353f7df497101eef17729eefe
TheModMaker
approved these changes
Jun 15, 2021
github-actions
bot
added
the
status: archived
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make shared_library builds work on Windows with MSVS 2019, this
commit:
Status class.
libpackager, now that File is exported
instruct the linker to import Status and File from the library
Closes #318 (shared_library builds on Windows)
Issue #336 (progress toward GitHub Actions workflow to replace Travis
and Appveyor, where we need to build and test shared_library on all
platforms)
b/190743862 (internal; tracking replacement of Travis)