This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Support search for more than 200 tickets #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanSheridan11
force-pushed
the
search-tickets-max-results
branch
from
639031c to
62fca2f
Compare
alto
reviewed
Oct 15, 2021
RyanSheridan11
force-pushed
the
search-tickets-max-results
branch
from
62fca2f to
384d309
Compare
The search_tickets function should now get up to 5000 tickets. It does this by making multiple requests with pagination at the maximum amount of 500 per request
RyanSheridan11
force-pushed
the
search-tickets-max-results
branch
from
384d309 to
0a6ec8a
Compare
alto
suggested changes
Oct 18, 2021
lib/vimaly/client.rb
Outdated
| Ticket.from_vimaly(search_response, ticket_type_map, bin_map, custom_fields) | ||
| end | ||
|
|
||
| break unless search_response # If reponse is nil then we know we've got all the data |
There was a problem hiding this comment.
You could use a case statement for this, like this:
response_tickets = case search_response
when Array
...
when Hash
else # or when NilClass
break
end
lib/vimaly/client.rb
Outdated
| Ticket.from_vimaly(ticket_data, ticket_type_map, bin_map, custom_fields) | ||
| end | ||
| elsif search_response.instance_of? Hash # Will be a hash when only 1 ticket is returned. (most likely because max_results is 1) | ||
| Ticket.from_vimaly(search_response, ticket_type_map, bin_map, custom_fields) |
There was a problem hiding this comment.
You could return [Ticket.from_vimaly(search_response, ticket_type_map, bin_map, custom_fields)] here, which allows you to not check for unless search_response.instance_of? Hash below.
lib/vimaly/client.rb
Outdated
| break if response_tickets.size < max_results # Can finish search because we've returned all there is. | ||
| end | ||
|
|
||
| tickets << response_tickets |
There was a problem hiding this comment.
response_tickets is an Array and tickets is an Array, right? Then << doesn't do what you think it does (adding the content of one to the other), it adds the response_tickets as one item into tickets. You can do this instead:
ticket += response_tickets
alto
changed the title
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix up the search_tickets method so I can use it to search for a bunch of trade confirmation tickets to rerun.
It looks like theres about 700 or so tickets that I need to find in the search