-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement new flag for printing the executed commands #1068
base: master
Are you sure you want to change the base?
Conversation
Questions: 1. Why not using |
So the answer to both: kind of just went by what was proposed in the issue. At least for the short option, I think I'll remove that |
I agree with you and have thus updated the proposal. |
Fixed the last style warnings, now ready for review. Hope the implementation is satisfactory, tried to keep changes to existing logic minimal and did my best to make sure the runtime performance is not impacted with unnecessary overhead, at least when not using the new flag. |
Pushed a couple more commits, noticed printing was broken for multiple command instances. Now works with those as well. |
Thank you very much for your contribution! This looks good from a very high level, but I'll probably need some more time to review this in detail. If there are any things in here that could be split out into a separate PR (and are useful independent from this feature), that would be very much appreciated. |
wish I had something more constructive to say other than I'm just hyped for this feature and looking forward to it being merged 👀 . Sounds much better than keep |
Implementation for #1042, flag
--print-exec
The flag causes the commands that are going to be executed to first be printed with colored highlighting. Highlighting uses the same logic as when running fd and just listing results. The highlighting is also applied to templates.
TODO: