Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Argument --block-size=0 should be considered an error. #110

Closed
eth-p opened this issue Oct 23, 2020 · 1 comment · Fixed by #120
Closed

Argument --block-size=0 should be considered an error. #110

eth-p opened this issue Oct 23, 2020 · 1 comment · Fixed by #120
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eth-p
Copy link

eth-p commented Oct 23, 2020

Using --length=16block with --block-size=0 is the same thing as doing --length=0, and it doesn't make much sense to do intentionally.

Related: #106


Note: I'm doing a class assignment regarding creating tests (from scratch) for an open-source command line program, and I chose hexyl for it. You might have a couple more of these on the way, depending on what the assignment brings to light :)

@sharkdp
Copy link
Owner

sharkdp commented Oct 24, 2020

Thanks. We should disallow block sizes of 0.

@sharkdp sharkdp closed this as completed Oct 24, 2020
@sharkdp sharkdp reopened this Oct 24, 2020
@sharkdp sharkdp added good first issue Good for newcomers enhancement New feature or request labels Oct 24, 2020
sharkdp added a commit that referenced this issue Oct 31, 2020
sharkdp added a commit that referenced this issue Oct 31, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants