-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow hex numbers and data units for block size argument #144
Allow hex numbers and data units for block size argument #144
Conversation
Having this as an own function allows special handling of the 'block' unit in --block-size argument.
Thank you very much for your contribution! This looks great on a first glance. Happy to review it in detail after the cleanup.
I didn't know this crate. That sounds really helpful. Bumping to Rust 1.46 sounds good. Since this only affects hexyl as a tool and not hexyl as a library, I'd be okay to bump it even further, in case that helps with other parts of the code. I don't think we have a lot of "customers" anyway: https://crates.io/crates/hexyl/reverse_dependencies |
Please let me know if you have other concerns/ideas/suggestions etc. :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. Great work on the refactoring - this looks much cleaner now! I looked closely but I don't have any additional comments ;-)
Summary
Closes #111
This PR allows arguments like
4kb
or0x10
for--block-size
.The 'block' unit is not allowed in this context (see discussion on related issue).