-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement builder pattern #168
Conversation
Let me know if there are any bikeshed quibbles with the naming of methods and I'll be happy to change them! |
Awesome, thank you very much! Could you please add an entry to the "unreleased" section in |
One last thing: do you feel it's necessary to add documentation to the new |
Thank you for your concern. Adding documentation is always great, but I wouldn't see this as a requirement for this PR. This changeset already improves hexyl as a library significantly. There was no documentation before because - to be honest - I only support hexyl-the-public-library in a "best effort" manner. So I suggest we merge this as is, but new PRs are always welcome of course! |
That should be everything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
As discussed in my previous pull request, this pull request deprecates using the new method directly on the
Printer
struct, preferring thePrinterBuilder
struct for the builder pattern. This is a breaking change forhexyl
as a library.