Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bump edition to 2021 #389

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Bump edition to 2021 #389

merged 1 commit into from
Dec 28, 2023

Conversation

wcampbell0x2a
Copy link
Collaborator

Closes #356

@github-actions GitHub Actions
Copy link

Benchmark for 10c2454

Click to view benchmark
Test Base PR %
deku_read_bits 1231.8±13.88ns 1235.3±36.89ns +0.28%
deku_read_byte 20.8±0.32ns 21.1±0.43ns +1.44%
deku_read_enum 9.4±0.14ns 9.5±0.31ns +1.06%
deku_read_vec 58.1±3.73ns 58.3±1.00ns +0.34%
deku_write_bits 126.1±4.47ns 141.9±6.22ns +12.53%
deku_write_byte 132.1±5.10ns 127.9±2.94ns -3.18%
deku_write_enum 93.2±5.35ns 94.3±2.91ns +1.18%
deku_write_vec 3.1±0.03µs 3.1±0.04µs 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for 1680e06

Click to view benchmark
Test Base PR %
deku_read_bits 1212.8±34.73ns 1182.3±16.62ns -2.51%
deku_read_byte 20.8±0.17ns 21.1±0.39ns +1.44%
deku_read_enum 9.4±0.12ns 9.4±0.15ns 0.00%
deku_read_vec 57.9±0.71ns 58.5±1.38ns +1.04%
deku_write_bits 126.0±5.47ns 138.6±10.76ns +10.00%
deku_write_byte 138.3±7.83ns 130.6±4.81ns -5.57%
deku_write_enum 91.6±4.69ns 95.5±6.77ns +4.26%
deku_write_vec 3.1±0.05µs 3.1±0.05µs 0.00%

sharksforarms
sharksforarms previously approved these changes Dec 28, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

Benchmark for 5f413ba

Click to view benchmark
Test Base PR %
deku_read_bits 1227.5±12.15ns 1196.4±10.02ns -2.53%
deku_read_byte 20.8±0.21ns 20.9±0.44ns +0.48%
deku_read_enum 9.6±0.15ns 9.4±0.16ns -2.08%
deku_read_vec 57.3±0.62ns 59.0±0.72ns +2.97%
deku_write_bits 125.5±5.21ns 132.4±2.35ns +5.50%
deku_write_byte 129.5±5.77ns 133.6±5.93ns +3.17%
deku_write_enum 93.8±3.81ns 93.6±4.76ns -0.21%
deku_write_vec 3.1±0.08µs 3.1±0.06µs 0.00%

@wcampbell0x2a wcampbell0x2a merged commit 91f03e1 into master Dec 28, 2023
@wcampbell0x2a wcampbell0x2a deleted the bump-edition-2021 branch December 28, 2023 15:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sharksforarms sharksforarms sharksforarms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump edition to Rust 2021
2 participants
@wcampbell0x2a @sharksforarms