Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update deps #438

Merged
merged 6 commits into from
May 22, 2024
Merged

Update deps #438

merged 6 commits into from
May 22, 2024

Conversation

sharksforarms
Copy link
Owner

Update all dependencies

@github-actions GitHub Actions
Copy link

Benchmark for d80935d

Click to view benchmark
Test Base PR %
deku_read_bits 1250.4±19.52ns 1315.6±33.57ns +5.21%
deku_read_byte 3.3±0.05ns 3.5±0.03ns +6.06%
deku_read_enum 2.6±0.05ns 3.0±0.06ns +15.38%
deku_read_vec 34.4±0.41ns 35.5±0.39ns +3.20%
deku_write_bits 146.3±2.84ns 154.8±6.06ns +5.81%
deku_write_byte 21.8±0.42ns 22.2±0.49ns +1.83%
deku_write_enum 21.1±0.38ns 21.4±0.35ns +1.42%
deku_write_vec 330.7±6.41ns 333.3±3.24ns +0.79%

@sharksforarms sharksforarms force-pushed the sharksforarms/update-deps branch from c0a8144 to 8927c63 Compare May 14, 2024 22:32
@sharksforarms sharksforarms marked this pull request as ready for review May 14, 2024 22:33
@github-actions GitHub Actions
Copy link

Benchmark for efd11e0

Click to view benchmark
Test Base PR %
deku_read_bits 1278.6±17.29ns 1303.9±11.26ns +1.98%
deku_read_byte 3.3±0.03ns 3.3±0.04ns 0.00%
deku_read_enum 2.5±0.08ns 2.6±0.05ns +4.00%
deku_read_vec 34.0±0.56ns 35.5±0.54ns +4.41%
deku_write_bits 168.5±3.55ns 154.5±2.44ns -8.31%
deku_write_byte 22.1±0.32ns 22.8±2.29ns +3.17%
deku_write_enum 21.4±0.21ns 21.4±0.42ns 0.00%
deku_write_vec 382.4±7.19ns 379.5±3.45ns -0.76%

@wcampbell0x2a
Copy link
Collaborator

@sharksforarms looks like some failure.

Also, I think you need to add a codecov ci token to fix the coverage step.

error: failed to select a version for `env_logger`.
    ... required by package `deku v0.16.0 (/home/runner/work/deku/deku)`
versions that meet the requirements `^0.11.3` are: 0.11.3

the package `deku` depends on `env_logger`, with features: `anstream` but `env_logger` does not have these features.
 It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.

@sharksforarms sharksforarms force-pushed the sharksforarms/update-deps branch from 8927c63 to 9f77a51 Compare May 21, 2024 16:44
@sharksforarms
Copy link
Owner Author

@wcampbell0x2a updated the msrv to 1.71 (same as env_logger), do you see this being an issue?

I see 1.75.0 in my apt repos, I suspect 1.71 is ok.

@sharksforarms sharksforarms force-pushed the sharksforarms/update-deps branch from 9f77a51 to 174857e Compare May 21, 2024 16:47
@github-actions GitHub Actions
Copy link

Benchmark for 4bbc62e

Click to view benchmark
Test Base PR %
deku_read_bits 1324.8±10.81ns 1414.4±50.61ns +6.76%
deku_read_byte 3.4±0.14ns 3.5±0.06ns +2.94%
deku_read_enum 2.5±0.06ns 3.0±0.07ns +20.00%
deku_read_vec 35.8±0.50ns 35.6±0.26ns -0.56%
deku_write_bits 155.8±3.33ns 148.7±3.84ns -4.56%
deku_write_byte 23.1±0.25ns 22.1±0.56ns -4.33%
deku_write_enum 21.1±0.22ns 21.4±0.28ns +1.42%
deku_write_vec 329.5±4.38ns 328.5±3.22ns -0.30%

@github-actions GitHub Actions
Copy link

Benchmark for 9e48554

Click to view benchmark
Test Base PR %
deku_read_bits 1237.4±13.13ns 1311.2±17.50ns +5.96%
deku_read_byte 3.5±0.09ns 3.3±0.04ns -5.71%
deku_read_enum 2.8±0.07ns 2.6±0.06ns -7.14%
deku_read_vec 34.3±0.56ns 35.4±0.34ns +3.21%
deku_write_bits 150.4±4.93ns 148.1±2.59ns -1.53%
deku_write_byte 21.9±0.31ns 22.1±0.34ns +0.91%
deku_write_enum 21.1±0.24ns 21.4±0.39ns +1.42%
deku_write_vec 397.0±3.87ns 393.3±7.82ns -0.93%

@github-actions GitHub Actions
Copy link

Benchmark for 20f5f04

Click to view benchmark
Test Base PR %
deku_read_bits 1249.0±16.82ns 1342.2±16.81ns +7.46%
deku_read_byte 3.4±0.04ns 3.3±0.08ns -2.94%
deku_read_enum 2.5±0.07ns 2.6±0.06ns +4.00%
deku_read_vec 34.2±0.42ns 35.6±0.42ns +4.09%
deku_write_bits 161.7±3.41ns 151.8±4.36ns -6.12%
deku_write_byte 21.8±0.33ns 22.4±0.91ns +2.75%
deku_write_enum 21.3±0.57ns 21.5±0.54ns +0.94%
deku_write_vec 460.1±3.79ns 398.1±5.01ns -13.48%

@github-actions GitHub Actions
Copy link

Benchmark for 2d134a8

Click to view benchmark
Test Base PR %
deku_read_bits 1265.1±30.15ns 1327.9±22.04ns +4.96%
deku_read_byte 3.4±0.04ns 3.5±0.12ns +2.94%
deku_read_enum 2.5±0.08ns 3.0±0.07ns +20.00%
deku_read_vec 34.0±0.26ns 35.9±1.10ns +5.59%
deku_write_bits 150.5±2.66ns 146.4±3.46ns -2.72%
deku_write_byte 21.8±0.23ns 22.1±0.32ns +1.38%
deku_write_enum 21.1±0.34ns 21.6±0.90ns +2.37%
deku_write_vec 328.6±4.79ns 337.6±5.19ns +2.74%

@github-actions GitHub Actions
Copy link

Benchmark for 3b95437

Click to view benchmark
Test Base PR %
deku_read_bits 1305.0±34.57ns 1302.7±15.62ns -0.18%
deku_read_byte 3.6±0.18ns 3.3±0.07ns -8.33%
deku_read_enum 2.8±0.07ns 2.6±0.05ns -7.14%
deku_read_vec 34.4±1.10ns 35.6±1.69ns +3.49%
deku_write_bits 163.4±4.39ns 148.0±3.52ns -9.42%
deku_write_byte 21.9±0.36ns 22.1±0.43ns +0.91%
deku_write_enum 21.1±0.37ns 21.4±0.33ns +1.42%
deku_write_vec 401.2±8.77ns 388.5±5.40ns -3.17%

@sharksforarms sharksforarms force-pushed the sharksforarms/update-deps branch 3 times, most recently from f9cb664 to c9cc67a Compare May 21, 2024 17:21
@github-actions GitHub Actions
Copy link

Benchmark for 532e6bb

Click to view benchmark
Test Base PR %
deku_read_bits 1247.2±23.47ns 1364.4±38.31ns +9.40%
deku_read_byte 3.4±0.09ns 3.3±0.06ns -2.94%
deku_read_enum 2.5±0.06ns 2.6±0.06ns +4.00%
deku_read_vec 34.1±0.53ns 37.1±0.58ns +8.80%
deku_write_bits 156.4±8.31ns 147.6±4.16ns -5.63%
deku_write_byte 22.0±0.39ns 22.1±0.41ns +0.45%
deku_write_enum 21.4±0.28ns 21.5±0.75ns +0.47%
deku_write_vec 328.2±3.78ns 334.7±7.68ns +1.98%

@github-actions GitHub Actions
Copy link

Benchmark for 78b76b9

Click to view benchmark
Test Base PR %
deku_read_bits 1259.0±11.49ns 1316.8±50.88ns +4.59%
deku_read_byte 3.4±0.07ns 3.3±0.04ns -2.94%
deku_read_enum 2.5±0.05ns 2.6±0.07ns +4.00%
deku_read_vec 34.3±0.56ns 35.6±0.64ns +3.79%
deku_write_bits 152.7±2.78ns 155.3±5.61ns +1.70%
deku_write_byte 21.8±0.41ns 22.1±0.22ns +1.38%
deku_write_enum 21.2±1.01ns 21.4±0.36ns +0.94%
deku_write_vec 330.0±4.50ns 316.1±5.92ns -4.21%

@sharksforarms sharksforarms force-pushed the sharksforarms/update-deps branch from c9cc67a to b8e8c65 Compare May 21, 2024 17:25
@github-actions GitHub Actions
Copy link

Benchmark for b0476b1

Click to view benchmark
Test Base PR %
deku_read_bits 1293.9±21.16ns 1318.3±21.07ns +1.89%
deku_read_byte 3.4±0.10ns 3.3±0.06ns -2.94%
deku_read_enum 2.6±0.07ns 2.6±0.05ns 0.00%
deku_read_vec 34.1±0.55ns 36.0±0.72ns +5.57%
deku_write_bits 148.6±4.13ns 159.7±5.51ns +7.47%
deku_write_byte 21.9±0.54ns 22.0±0.27ns +0.46%
deku_write_enum 21.1±0.31ns 21.4±0.36ns +1.42%
deku_write_vec 329.8±4.91ns 388.5±4.49ns +17.80%

@github-actions GitHub Actions
Copy link

Benchmark for ebc142d

Click to view benchmark
Test Base PR %
deku_read_bits 1210.9±16.08ns 1313.2±23.63ns +8.45%
deku_read_byte 3.4±0.04ns 3.3±0.04ns -2.94%
deku_read_enum 2.5±0.05ns 2.6±0.06ns +4.00%
deku_read_vec 34.0±0.58ns 35.3±0.53ns +3.82%
deku_write_bits 153.0±13.11ns 150.5±3.71ns -1.63%
deku_write_byte 22.1±0.31ns 22.1±0.19ns 0.00%
deku_write_enum 21.4±0.36ns 21.4±0.35ns 0.00%
deku_write_vec 378.5±7.09ns 315.6±5.84ns -16.62%

@sharksforarms
Copy link
Owner Author

@wcampbell0x2a ready for review

wcampbell0x2a
wcampbell0x2a requested changes May 21, 2024
View reviewed changes
@sharksforarms sharksforarms force-pushed the sharksforarms/update-deps branch from c2e2de9 to 87f4485 Compare May 22, 2024 12:48
@github-actions GitHub Actions
Copy link

Benchmark for eb27b1c

Click to view benchmark
Test Base PR %
deku_read_bits 1196.9±19.24ns 1336.2±19.00ns +11.64%
deku_read_byte 3.4±0.06ns 3.5±0.09ns +2.94%
deku_read_enum 2.5±0.04ns 3.0±0.04ns +20.00%
deku_read_vec 34.7±0.68ns 35.3±0.38ns +1.73%
deku_write_bits 148.9±3.28ns 146.1±2.47ns -1.88%
deku_write_byte 22.1±0.27ns 22.1±0.54ns 0.00%
deku_write_enum 21.4±0.24ns 21.4±0.34ns 0.00%
deku_write_vec 331.2±9.45ns 327.0±6.16ns -1.27%

@github-actions GitHub Actions
Copy link

Benchmark for 4b38dcd

Click to view benchmark
Test Base PR %
deku_read_bits 1244.5±30.71ns 1328.0±30.00ns +6.71%
deku_read_byte 3.5±0.05ns 3.3±0.06ns -5.71%
deku_read_enum 2.8±0.05ns 2.6±0.07ns -7.14%
deku_read_vec 34.4±0.93ns 35.8±0.91ns +4.07%
deku_write_bits 149.6±2.91ns 152.0±4.41ns +1.60%
deku_write_byte 21.9±0.29ns 22.1±0.49ns +0.91%
deku_write_enum 21.1±0.18ns 21.5±0.39ns +1.90%
deku_write_vec 401.7±4.11ns 394.0±7.01ns -1.92%

@sharksforarms sharksforarms merged commit 184dca4 into master May 22, 2024
14 of 15 checks passed
@sharksforarms sharksforarms deleted the sharksforarms/update-deps branch May 22, 2024 15:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wcampbell0x2a wcampbell0x2a wcampbell0x2a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharksforarms @wcampbell0x2a