Add to_slice #461
Merged
Add to_slice #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for f979437Click to view benchmark
|
amin-mir
reviewed
Jul 16, 2024
src/lib.rs
Outdated
Comment on lines
538
to
540
| DekuWriter::to_writer(self, &mut __deku_writer, ()).unwrap(); | ||
| __deku_writer.finalize().unwrap(); |
There was a problem hiding this comment.
Is it okay to use unwrap() here? to_bytes is using ? to propagate the errors to the caller.
There was a problem hiding this comment.
Changed from unwrap
wcampbell0x2a
force-pushed
the
add-to-slice
branch
2 times, most recently
from
359ab28 to
b0d662a
Compare
Benchmark for 5be88f4Click to view benchmark
|
Benchmark for 15f0828Click to view benchmark
|
amin-mir
reviewed
Jul 18, 2024
| DekuWriter::to_writer(self, &mut __deku_writer, ())?; | ||
| __deku_writer.finalize()?; | ||
|
|
||
| Ok(__deku_writer.bits_written / 8) |
There was a problem hiding this comment.
There might be a corner case here. Would it handle the following case?
#[derive(Debug, PartialEq, DekuRead, DekuWrite)]
#[deku(endian = "big")]
struct DekuTest {
#[deku(bits = 4)]
field_a: u8,
field_b: u8,
}Let's say serializing this struct results in bits_written = 12 which means we need two bytes to store them into. But bits_written / 8 = 1. So I'm thinking either (bit_written + 8) / 8 or ceil() would be right way. What do you think?
There was a problem hiding this comment.
The above finalize call will fill in bits until it hits the byte boundary to make sure everything is written. This follows the logic of to_bytes.
wcampbell0x2a
added a commit
that referenced
this pull request
Sep 4, 2024
wcampbell0x2a
added a commit
that referenced
this pull request
Sep 4, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.