Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add webpack 5 support #195

Closed
otakustay opened this issue Nov 16, 2020 · 5 comments
Closed

Add webpack 5 support #195

otakustay opened this issue Nov 16, 2020 · 5 comments

Comments

@otakustay
Copy link

Feature Use Case

This plugin seems compatible to webpack 5, however npm 7 require exact peer dependencies match, since @pmmmwh/react-refresh-webpack-plugin has a peer dependent on it, it may affect all react-refresh users upgrading to npm 7.

Feature Proposal

Add webpack 5.x to peer dependency.

@shellscape
Copy link
Owner

We're waiting for Webpack 5 to stabilize before making that change, but we will make it. There are too many critical bugs still open in their repo.

@shellscape
Copy link
Owner

Since this is active in the minds of myself and the folks who curate this package, and that it was recommended in the Survive JS book just recently along Webpack 5, please rest assured that we're going to add support officially when the time is right.

@jesec
Copy link

jesec commented Feb 8, 2021

I second this. This plugin works perfectly fine so far with Webpack 5.x.

npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^4.20.2" from webpack-plugin-serve@1.2.1

npm 7 now mandates matching peer dependencies. Both npm 7 and Webpack 5 are now generally available. It does not hurt to simply accept Webpack 5.x as a valid peer dependency.

@TrySound
Copy link
Collaborator

TrySound commented Feb 8, 2021

Well, npm will be hated forever for this change.

@BenBeattieHood
Copy link

Just checking in on this, as it's been a few months - would you be willing to merge these changes in soon, or are there a specific set of issues on webpack 5 that you're waiting for resolution on?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants