Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Mark Webpack 5 as supported (#216) #217

Closed
wants to merge 1 commit into from
Closed

feat: Mark Webpack 5 as supported (#216) #217

wants to merge 1 commit into from

Conversation

denis-sokolov
Copy link

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

Please Describe Your Changes

Default Webpack version is now 5, discussed in #216.

Although considering the readme of this project suggests webpack-nano, perhaps a better option is to remove the peer dependency altogether.

@shellscape
Copy link
Owner

folks, while I appreciate the contributions and the interest in the project, I really need everybody to start searching issues before opening new ones. I have addressed this several times and have stated several times that I will switch to webpack 5 for this project when I feel that the time is right. thanks again, but I cannot accept your pull request at this time

@shellscape shellscape closed this Mar 1, 2021
@denis-sokolov denis-sokolov deleted the webpack-5 branch March 1, 2021 13:46
@denis-sokolov
Copy link
Author

Sincere apologies. I’ve assumed that since the issue above (#216) is open and mentioned Webpack 5 as working fine, I’d reduce the friction to integrate it.

Perhaps keeping a Webpack 5 issue like #195 open would help? From the point of view of consumers missing Webpack 5 support is an outstanding concern that, and an open issue communicates it very clearly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants