Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add symbols in expandEnvVariablesWithDefaults regexp #7

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

sergazyyev
Copy link
Contributor

(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

Improve expandEnvVariablesWithDefaults func in order to being able take default values strings that contains ':' (colon) and ',' (comma) symbols. In my case I need to add to default value host addresses in format like host1:3333,host1:2222,host3,4477

@coveralls
Copy link

coveralls commented Sep 25, 2022

Pull Request Test Coverage Report for Build 222fc4df6b1156380ed10dc2777610731c80a46d-PR-7

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.871%

Totals Coverage Status
Change from base Build 12edf60b8d971efcd821faef46eb4292d09c3aea: 0.0%
Covered Lines: 438
Relevant Lines: 482

💛 - Coveralls

@sherifabdlnaby
Copy link
Owner

LGTM 🍻

@sherifabdlnaby sherifabdlnaby merged commit 3fd2d37 into sherifabdlnaby:master Sep 25, 2022
@sergazyyev
Copy link
Contributor Author

Thanks, could you please add minor release tag for this merge?

@sherifabdlnaby
Copy link
Owner

@sergazyyev Thought I had automation for that 😅... Added ✅

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants