Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

removed falsepositives #2360

Conversation

elvirvelagic
Copy link

@elvirvelagic elvirvelagic commented Nov 7, 2024

I removed false positives in the issue #2318. The sites were removed from the data.json file and I added them to the removed-sites.md file. 16 websites was removed in total and there is probably more false positives out there but these should the the most common.

NOTE: Twitch.tv should be readded since it is a very popular site

@bytexenon
Copy link
Contributor

bytexenon commented Nov 8, 2024

Thanks a ton for taking the time to contribute to the project. Most of those sites that show false positives seem to have just changed their URL structure for user profiles, but it might take quite some time for us to fix them. It might be a good idea to temporarily remove them to avoid false positives while we work on updating the data.json entries for them. This will help to keep the output of Sherlock cleaner

By the way, I think Reddit and 1337x also return false positives. You could consider adding them as well, but it's optional

@elvirvelagic
Copy link
Author

Thank you will look into it and hopefully fix a few of the links and readd them. 1337x was down all day so it didn't give me a false positive. I added the removed links in the wrong order in the removed-sites.md file will fix that aswell.

@ppfeister
Copy link
Member

So, I was conducting a review, and my comment on each change ended up being copied and pasted straight down the line --- only about 2 or 3 changed targets in the beginning behaved as indicated. Stopped about halfway. All of these except the aforementioned few fail to provide a false positive or negative (barring the intentional negatives due to WAF filtering, indicated by --print-all). It is very possible that this is due to regional differences in delivery. @Vikranth3140 if you're experiencing false positives/negatives on these targets, please provide the --dump-response for each target in a bespoke issue so the presumed regional differences can be resolved.

I'll be closing these for now since there are simply too many targets being handled at once that are behaving quite sporadically, but they can be re-opened if need be

The few targets that I was able to confirm as being problematic, and without a readily available fix, will be removed with @elvirvelagic as a co-author on the commit (given his changes here).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants