Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/nanobind v2.0.0 #68

Merged
merged 3 commits into from
May 30, 2024
Merged

Feature/nanobind v2.0.0 #68

merged 3 commits into from
May 30, 2024

Conversation

voluntas
Copy link
Member

@voluntas voluntas commented May 30, 2024

This pull request includes changes mainly focused on code simplification, performance improvement, and updating dependencies. The most significant changes are the replacement of nb::shape<nb::any, nb::any> with nb::shape<-1, -1> in several files, the update of the nanobind dependency in pyproject.toml, and the addition of new file associations in .vscode/settings.json.

Code simplification and performance improvement:

  • Changes in several files including src/sora_audio_sink.cpp, src/sora_audio_sink.h, src/sora_audio_source.cpp, src/sora_audio_source.h, src/sora_audio_stream_sink.cpp, src/sora_audio_stream_sink.h, src/sora_video_sink.cpp, src/sora_video_sink.h, src/sora_video_source.cpp, src/sora_video_source.h, src/sora_sdk_ext.cpp: Replaced nb::shape<nb::any, nb::any> with nb::shape<-1, -1> to simplify the code and potentially improve performance. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]

Dependency update:

  • pyproject.toml: Updated the nanobind dependency from 1.9.2 to 2.0.0.

File associations:

  • .vscode/settings.json: Added new file associations for .cs and CMakeLists.txt files, and added compare and concepts to the list of cpp files. [1] [2]

Performance improvement:

  • run.py: Modified the cmake command to use all available CPU cores during the build process.

Code addition:

  • run.py: Imported the multiprocessing module to get the number of available CPU cores.

@voluntas voluntas marked this pull request as ready for review May 30, 2024 08:49
@voluntas voluntas merged commit df7a3f7 into develop May 30, 2024
22 checks passed
@voluntas voluntas deleted the feature/nanobind-v2.0.0 branch May 30, 2024 08:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants