memory: expose virtual totals / avail values on windows #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sni
added a commit
to ConSol-Monitoring/snclient
that referenced
this pull request
Jan 26, 2024
pull request openened to expose those values: shirou/gopsutil#1588
|
Thank you for your contribute. However, we don't want to add platform specific fields anymore. We have a v4 plan which introduces platform specific structs. We will be able to add fields on it, but not developed yet. |
There are 2 more memory values i'd like to use. They are there already, just not exposed by the module. - https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/ns-sysinfoapi-memorystatusex Signed-off-by: Sven Nierlein <sven@consol.de>
shirou
added a commit
that referenced
this pull request
Feb 24, 2024
This commit fixes #1588. Thank you!
shirou
added a commit
that referenced
this pull request
Feb 24, 2024
This commit fixes #1588. Thank you!
shirou
added a commit
that referenced
this pull request
Feb 24, 2024
This commit fixes #1588. Thank you!
shirou
added a commit
that referenced
this pull request
Mar 10, 2024
This commit fixes #1588. Thank you!
shirou
added a commit
that referenced
this pull request
Apr 22, 2024
This commit fixes #1588. Thank you!
|
that's great, thank you very much. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 more memory values i'd like to use. They are there already, just not exposed by the module yet.