Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(mem): Add windows commit stats #1720

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

n4nn31355
Copy link
Contributor

@n4nn31355 n4nn31355 commented Oct 3, 2024

I'm kinda puzzled if I should avoid calling procGetPerformanceInfo and stick to computing commit stats from memoryStatusEx.ullTotalPageFile and memoryStatusEx.ullAvailPageFile or expose pagefile stats and compute it in final application.

However, I chose this implementation because it is more aligned with the terminology used by Windows Task Manager and Powershell's Get-Counter, both of which refer to "commit" rather than "pagefile."

Closes #1719

Closes Expose MemCommit info for Windows shirou#1719
@n4nn31355
Copy link
Contributor Author

@shirou just a gentle reminder
Could you please let me know if this can be merged or if you have any feedback I should address?

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delayed response. I've been too busy over the past two months.

I have confirmed that your PR works correctly on my Windows 11. Additionally, I verified that at least commitLimit matches the following PowerShell command. We appreciate your contribution!

$MemCounters = (Get-Counter -ListSet Memory).Paths
Get-Counter -Counter $MemCounters

@shirou shirou merged commit aa47e0f into shirou:master Oct 23, 2024
23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose MemCommit info for Windows
2 participants