Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run E2E tests with RoadRunner by default #1786

Closed
3 tasks done
acelaya opened this issue May 21, 2023 · 2 comments · Fixed by #2002
Closed
3 tasks done

Run E2E tests with RoadRunner by default #1786

acelaya opened this issue May 21, 2023 · 2 comments · Fixed by #2002
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented May 21, 2023

TODO:

@acelaya
Copy link
Member Author

acelaya commented Jun 20, 2023

Blocked by RoadRunner not supporting code coverage generation via pcov or xdebug

@acelaya acelaya added the blocked Issues with some external dependency preventing to work on them label Jun 20, 2023
@acelaya acelaya removed this from the 3.7.0 milestone Jun 20, 2023
@acelaya acelaya added this to the 4.0.0 milestone Nov 4, 2023
@acelaya acelaya moved this to Todo in Shlink Feb 1, 2024
@acelaya acelaya moved this from Todo to In Progress in Shlink Feb 4, 2024
@acelaya
Copy link
Member Author

acelaya commented Feb 15, 2024

In the end it turns out the missing coverage was not RoadRunner's fault. Instead, I had to move the .rr.yml config file used in tests to the project root, and everything started to work.

@acelaya acelaya removed the blocked Issues with some external dependency preventing to work on them label Feb 15, 2024
@acelaya acelaya moved this from In Progress to In review in Shlink Feb 15, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Feb 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant