Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/rr e2e tests #2002

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 15, 2024

Closes #1786

  • Change the default runtime for API tests to RoadRunner. This paves the road to completely remove openswoole from the project.
  • Create a rr.test.yml config file in the project root, to use with API tests. If the config file is located in a subdirectory, code coverage collection does not work.

@acelaya acelaya force-pushed the feature/rr-e2e-tests branch from acf176c to d949b54 Compare February 15, 2024 22:40
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37e0978) 96.80% compared to head (1117631) 96.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2002   +/-   ##
==========================================
  Coverage      96.80%   96.80%           
  Complexity      1317     1317           
==========================================
  Files            245      245           
  Lines           4566     4566           
==========================================
  Hits            4420     4420           
  Misses           146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review February 15, 2024 22:44
@acelaya acelaya merged commit 72c4628 into shlinkio:develop Feb 16, 2024
33 checks passed
@acelaya acelaya deleted the feature/rr-e2e-tests branch February 16, 2024 06:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run E2E tests with RoadRunner by default
1 participant