Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/url validation memory issue #1440

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented May 1, 2022

Closes #1439

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #1440 (18f656f) into main (68e0aa1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1440      +/-   ##
============================================
+ Coverage     96.52%   96.53%   +0.01%     
- Complexity     1236     1241       +5     
============================================
  Files           195      195              
  Lines          3592     3603      +11     
============================================
+ Hits           3467     3478      +11     
  Misses          125      125              
Impacted Files Coverage Δ
module/Core/src/Util/UrlValidator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e0aa1...18f656f. Read the comment docs.

…content is tried to be downloaded, and only until the title tag has been parsed
@acelaya acelaya marked this pull request as ready for review May 1, 2022 09:49
@acelaya acelaya merged commit 2d51bd8 into shlinkio:main May 1, 2022
@acelaya acelaya deleted the feature/url-validation-memory-issue branch May 1, 2022 10:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants