Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/default php 8.3 #1998

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 11, 2024

Closes #1909

  • Update docker images (prod and dev ones) to PHP 8.3
  • Update APCu, pdo_sqlsrv and openswoole to versions compatible with PHP 8.3
  • No longer allow failures when running CI on PHP 8.3
  • Do not ignore PHP platform req when installing deps

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (522d021) 96.93% compared to head (7a6bfed) 96.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1998   +/-   ##
==========================================
  Coverage      96.93%   96.93%           
  Complexity      1355     1355           
==========================================
  Files            250      250           
  Lines           4696     4696           
==========================================
  Hits            4552     4552           
  Misses           144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit cc4afa7 into shlinkio:develop Feb 11, 2024
34 checks passed
@acelaya acelaya deleted the feature/default-php-8.3 branch February 11, 2024 10:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PHP 8.3 the default
1 participant