Fix textarea resizing bug #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o konnorrogers/fix-textarea-resizing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
claviska
approved these changes
Sep 30, 2024
qwtel
added a commit
to qwtel/shoelace
that referenced
this pull request
Nov 9, 2024
This reverts commit 61f2fdb. # Conflicts: # docs/pages/resources/changelog.md
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2180
This is some weird mix of https://chriscoyier.net/2023/09/29/css-solves-auto-expanding-textareas-probably-eventually/ and the existing code.
I tested it in:
Chrome 129
Firefox 130.1
Safari 17.5
and it seems to fix the scroll jumping.
Here's the "fixed" fiddle:
https://jsfiddle.net/n158gvy7/3/