Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing this as an alternative to #39, basically just because #39 is several years old. (Changes to both this gem and rubocop cops make it easier to redo that work, in my opinion.)
This PR now passes
bundle exec rake
, both its rubocop check and its test suite. It's noisy but it passes. 🎉I don't think any of these changes are unusual. I'm happy to discuss/defend my choices. I don't have strongly held opinions about any of this.
One change is fixing my own mistake with rescuing both an exception class and one of its subclasses (oops).
I would suggest switching CI from Travis to GitHub Actions as a more modern approach, and when doing that pick a range of ruby releases that fits with whatever
required_ruby_version
you pick. I picked>= 2.4
pretty arbitrarily. That version's been EOL for 2 years and supporting earlier versions is probably not necessary at this point.For the first commit, I just ran
rubocop --auto-correct
and skimmed the resulting diff. Generally I trust rubocop's autocorrections when they are listed as safe. The remaining commits were all inspected carefully or hand-written.This all ran with rubocop 1.29.0 except I think the first auto-correct ran with 1.26.0.