Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove dependency on Rhino.Mocks #51

Closed
dirkrombauts opened this issue Nov 14, 2012 · 6 comments
Closed

Remove dependency on Rhino.Mocks #51

dirkrombauts opened this issue Nov 14, 2012 · 6 comments
Milestone

Comments

@dirkrombauts
Copy link

Hi,

Are there any plans to release a new version of Shoudly, where the dependency to Rhino.Mocks is removed? According to semver, this new version should be called 2.0.0 :-)

Dirk

@xerxesb
Copy link
Member

xerxesb commented Nov 14, 2012

Hi Dirk,

The dependency to Rhino was deprecated some time ago, meaning unless you actually use Shouldly's ShouldHaveBeenCalled method, you won't need to deploy the Rhino.Mocks assembly. It was removed from the NuGet package at the same time.

Are you having a specific issue with the current version?

Thanks,
Xerx

@dirkrombauts
Copy link
Author

Hi Xerx,

Thanks for getting back to me.

Yes, I do have a specific issue with the current version. I'm trying to run our tests using mstest.exe from the command line (rather than from within visual studio) and mstest complains (writes a warning) about not finding Rhino.Mocks - even though I don't use the Rhino-related methods.

Dirk

@xerxesb
Copy link
Member

xerxesb commented Nov 15, 2012

I'm more than happy to remove Rhino as a dependency completely. The deprecation has been in there for a while so i'm not afraid that anyone would be crippled by the change to the API.

Going through the existing issues list, there are a number of things i'd like to introduce/fix before I throw around the v2 moniker. Admittedly things have been pretty quiet here as I've not had the need to extend or fix Shouldly in some time, but if not for the sake of marking v2 then i'm happy to do them.

The only problem is that this change might not come anytime soon (ie: could be a few weeks while i do it piecemeal on the side). I'm happy to make a pre-release version available to you, if it can't wait that long?

@dirkrombauts
Copy link
Author

Thanks, a pre-release version would be cool!

@xerxesb
Copy link
Member

xerxesb commented Nov 16, 2012

Hi Dirk,

I've created an unversioned build of Shouldly sans Rhino Mocks. It worked in my quick test of MSTest - i'd appreciate if you could run it against your build and let me know if that solves your problem?

You should be able to just drop these files ontop of your existing Shouldly.dll/pdb files, compile and test.

https://github.com/downloads/shouldly/shouldly/Shouldly%20-%20Pre%20Release%20Without%20Rhino%20Mocks.zip

Cheers!

@dirkrombauts
Copy link
Author

Thanks for the prerelease version! Yes, that works - MSTest is happy now :-)

xerxesb added a commit that referenced this issue Jan 16, 2013
becdetat pushed a commit to becdetat/shouldly that referenced this issue Feb 1, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants