Convert to sublime color scheme #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s logic: lighter variants start at 1 and each increment is darker.
… in green and italic instead of orange-red and bold.
…punction was colored) and background of code block with darker tone.
…ause I was prefixing with green. Closes Honiix/glacier-theme#1
…s pink. Added Purple. Removed black-1 -> use blue-dark-2 instead. Rename light to bright.
|
Thank you for doing this, @Honiix! I'll take a look at this over lunch. |
joeyfigaro
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
I saw one instance of a potential typo, but I'm not familiar with the tools/tech used for the work—thank you so much for your contribution/work! This is a huge update for a project that's been neglected, to say the least. Barring the potential typo, this looks good to me.
| "key2": "value2", | ||
| } | ||
| ], | ||
| "glosrsay": { |
There was a problem hiding this comment.
Yep, it's a typo, could be "Glossary". But it's just a sample file used to test the colors. It has no impact on the theme.
There was a problem hiding this comment.
Cool, thanks for clarifying 💯
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose a new color scheme with :
The original color scheme is kept in glacier-legacy.tmTheme