Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Keep original lastRect to fix some drawing glitches (e.g. in ErrorRow) #34

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

veger
Copy link
Collaborator

@veger veger commented Feb 13, 2024

#31 was missing an additional fix for the scroll area and their scrollbars.
With this I did not see any glitches anymore, and the ScrollArea size is set correctly now (showing scrollbars if needed).(hard to see/test, as it was visible for the Summary tab which will be my next PR)

Adding a lastContentRect which contains the (correct/out-of-window) size, fixes the contentSize calculation in BuildGui().

Adding a lastContentRect which contains the (correct/out-of-window)
size, fixes the contentSize calculation in BuildGui().

I did not see any glich(es) anymore, and the ScrollArea size is set
correctly now (showing scrollbars if needed)
@shpaass shpaass force-pushed the fix-scrollbar-behavior branch from c1be00f to a457eb2 Compare February 14, 2024 23:42
@shpaass
Copy link
Owner

shpaass commented Feb 14, 2024

rebased on top of master

@shpaass
Copy link
Owner

shpaass commented Feb 14, 2024

No obvious errors on build and smoke testing.

@shpaass shpaass merged commit 856c455 into shpaass:master Feb 14, 2024
@veger veger deleted the fix-scrollbar-behavior branch February 15, 2024 07:25
shpaass added a commit that referenced this pull request Feb 29, 2024
I tried to reuse the existing UI of YAFC, so I based the whole thing on
a `ProjectPageContents` and a `ProjectPageView`, so it would be
recognized and fit into the `MainScreen` (tabs) and serialization.

The UI of the new 'Summary' tab is ugly, I tried making it nicer, but I
found it hard to understand the `ImGui` and its features and how to use
them... So I propose this could be further improved om in separate PRs
to get the basic functionality/feature into YAFC already and make it
available for everyone (I used it a lot and cannot live without this
anymore).

I also fixed some issues I found while implementing the Summary tab,
moved to #31 and #34, except for:
* calculating `DatGrid` width when header is not used (I found the
header useless here)

The original idea is from
ShadowTheAge#123
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants