Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix pop model_name #24

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix pop model_name #24

merged 1 commit into from
Feb 11, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Feb 10, 2024

I'm encountering an error where model_name is not in model_kwargs, if llm is not a string.

default_handler
    return chain(settings_override=settings_override)
  File "/Users/ahuang/miniconda3/envs/funcchain/lib/python3.10/site-packages/funcchain/syntax/executable.py", line 61, in chain
    chain: Runnable[dict[str, Any], Any] = compile_chain(sig, temp_images)
  File "/Users/ahuang/miniconda3/envs/funcchain/lib/python3.10/site-packages/funcchain/backend/compiler.py", line 209, in compile_chain
    return create_chain(
  File "/Users/ahuang/miniconda3/envs/funcchain/lib/python3.10/site-packages/funcchain/backend/compiler.py", line 102, in create_chain
    _llm = _gather_llm(settings)
  File "/Users/ahuang/miniconda3/envs/funcchain/lib/python3.10/site-packages/funcchain/backend/compiler.py", line 336, in _gather_llm
    llm = univeral_model_selector(settings)
  File "/Users/ahuang/miniconda3/envs/funcchain/lib/python3.10/site-packages/funcchain/model/defaults.py", line 158, in univeral_model_selector
    model_kwargs.pop("model_name")
KeyError: 'model_name'

Copy link
Owner

@shroominic shroominic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shroominic shroominic merged commit 9ade305 into shroominic:main Feb 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants