Skip to content

Commit c39b5df

Browse files
Fix milestone extraction, Fixes stephencelis#289
1 parent 8f7a6b8 commit c39b5df

File tree

3 files changed

+34
-6
lines changed

3 files changed

+34
-6
lines changed

ghi

+17-3
Original file line numberDiff line numberDiff line change
@@ -1568,9 +1568,24 @@ GitHub repository or by appending your command with the user/repo:
15681568
end
15691569
@issue
15701570
end
1571+
15711572
alias extract_issue issue
1572-
alias milestone issue
1573-
alias extract_milestone issue
1573+
1574+
def extract_milestone
1575+
return @milestone if defined? @milestone
1576+
extract_issue
1577+
if @issue
1578+
i = throb { api.get "/repos/#{repo}/issues/#{@issue}" }.body
1579+
if i["milestone"]
1580+
@milestone = i["milestone"]["number"]
1581+
else
1582+
@milestone = nil
1583+
end
1584+
end
1585+
@milestone
1586+
end
1587+
1588+
alias milestone extract_milestone
15741589

15751590
def infer_issue_from_branch_prefix
15761591
@issue = `git symbolic-ref --short HEAD 2>/dev/null`[/^\d+/];
@@ -2686,7 +2701,6 @@ EOF
26862701
def execute
26872702
self.action = 'index'
26882703
require_repo
2689-
extract_milestone
26902704

26912705
begin
26922706
options.parse! args

lib/ghi/commands/command.rb

+17-2
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,24 @@ def issue
108108
end
109109
@issue
110110
end
111+
111112
alias extract_issue issue
112-
alias milestone issue
113-
alias extract_milestone issue
113+
114+
def extract_milestone
115+
return @milestone if defined? @milestone
116+
extract_issue
117+
if @issue
118+
i = throb { api.get "/repos/#{repo}/issues/#{@issue}" }.body
119+
if i["milestone"]
120+
@milestone = i["milestone"]["number"]
121+
else
122+
@milestone = nil
123+
end
124+
end
125+
@milestone
126+
end
127+
128+
alias milestone extract_milestone
114129

115130
def infer_issue_from_branch_prefix
116131
@issue = `git symbolic-ref --short HEAD 2>/dev/null`[/^\d+/];

lib/ghi/commands/milestone.rb

-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ def options
8282
def execute
8383
self.action = 'index'
8484
require_repo
85-
extract_milestone
8685

8786
begin
8887
options.parse! args

0 commit comments

Comments
 (0)