Skip to content
This repository was archived by the owner on Mar 3, 2022. It is now read-only.

Milestone name inferred from branch prefix. #289

Closed
jmalloc opened this issue Apr 20, 2016 · 5 comments
Closed

Milestone name inferred from branch prefix. #289

jmalloc opened this issue Apr 20, 2016 · 5 comments

Comments

@jmalloc
Copy link

jmalloc commented Apr 20, 2016

Please let me know if I'm using this incorrectly - but it seems like there's an issue with the milestone subcommand whereby it uses the branch prefix (ie, issue number) as the milestone name.

$ ghi --version
ghi version 1.1.1

$ git branch | grep '*'
* 112-retain-strand-result

$ ghi milestone --list
(Inferring issue from branch prefix: #112)
Not Found
@AlexChesters
Copy link
Contributor

AlexChesters commented Apr 21, 2016

Hi there!

I don't believe this is an issue, ghi interacts with milestones by their number, rather than the milestone name.

E.g.:

ghi list --milestone
# AlexChesters/.emacs.d open milestones
  1: Version 1.0.0 

You would then add that milestone to issue 4 in the following way:
`ghi edit 4 -M 1'

Please comment if I haven't answered/understood your question!

@jmalloc
Copy link
Author

jmalloc commented Apr 25, 2016

The milestone command works fine when the master branch is checked out, but if the current branch name starts with a number and hyphen I get the error from my example above.

@caifara
Copy link

caifara commented May 23, 2016

I second that ghi milestone -l should list milestones whatever the current inferred issue.

There is this other issue: #198 which is a similar pain in my opinion (it's closed because one can opt out of inferring through a config option, but that's not really a good solution as inferring is really powerful).

I would state that there are two kinds of interesting commands, let's call them global commands (like ghi milestone -l and ghi new -m "") and local commands (like ghi show). Global commands should (imho) ignore the current working branch whereas local commands should always try to infer the issue number.

shubhamshuklaer added a commit to shubhamshuklaer/ghi that referenced this issue May 23, 2016
@shubhamshuklaer
Copy link
Collaborator

@jmalloc @caifara
For this issue check out this version
https://raw.githubusercontent.com/shubhamshuklaer/ghi/289_issue_inferring_not_found/ghi
and reply whether it fixes the issue.

shubhamshuklaer added a commit to shubhamshuklaer/ghi that referenced this issue May 23, 2016
@caifara
Copy link

caifara commented May 23, 2016

@shubhamshuklaer but but … I want to use the PR version too … ;-) Thx! (#288)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants