-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improve logs #72
Improve logs #72
Conversation
0, | ||
false | ||
) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move all this code into a unique function called generateLockFile
? I think it could be good to reduce the length of this file !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is a ticket in the roadmap to refactor this huge file :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool to discover the message module! ⭐️
return `${lineBreakString}${indentationString}${iconString}${chalk.reset( | ||
text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of the chalk.reset
? Do you any styled text going through this function?
Maybe a test could be a nice documentation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's possible to add some style without removing it, and Yeoman does that, which lead to different colors for messages printed with the same util, that's why I've added that.
For the test, I plan to write them in the future, there is a ticket too :)
No description provided.