Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve logs #72

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Improve logs #72

merged 3 commits into from
Oct 25, 2023

Conversation

ywolff
Copy link
Collaborator

@ywolff ywolff commented Oct 23, 2023

No description provided.

0,
false
)
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move all this code into a unique function called generateLockFile ? I think it could be good to reduce the length of this file !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a ticket in the roadmap to refactor this huge file :)

Copy link
Collaborator

@gdelepoulle gdelepoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool to discover the message module! ⭐️

Comment on lines +8 to +9
return `${lineBreakString}${indentationString}${iconString}${chalk.reset(
text
Copy link
Collaborator

@gdelepoulle gdelepoulle Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the chalk.reset? Do you any styled text going through this function?
Maybe a test could be a nice documentation!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's possible to add some style without removing it, and Yeoman does that, which lead to different colors for messages printed with the same util, that's why I've added that.
For the test, I plan to write them in the future, there is a ticket too :)

@ywolff ywolff merged commit 5d43271 into main Oct 25, 2023
@ywolff ywolff deleted the improve-logs branch October 25, 2023 15:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants