Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace black with ruff format #74

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Replace black with ruff format #74

merged 6 commits into from
Nov 13, 2023

Conversation

jack-mcivor
Copy link
Contributor

Not sure if this is something you want to do, but reduces installs & provides faster formatting. There will be better consistency with the ruff checks also.

ywolff
ywolff requested changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@ywolff ywolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! I'm fully aligned with you're suggestion, I had it in mind too! My feedback is mostly about naming.

generators/app/templates/common/pyproject.toml Outdated Show resolved Hide resolved
generators/app/templates/ci/.circleci/config.yml Outdated Show resolved Hide resolved
generators/app/templates/ci/.circleci/config.yml Outdated Show resolved Hide resolved
generators/app/templates/ci/.circleci/config.yml Outdated Show resolved Hide resolved
generators/app/templates/common/Makefile Outdated Show resolved Hide resolved
@jack-mcivor
Copy link
Contributor Author

Fixed those names & added a few more discussion points

ywolff
ywolff requested changes Nov 10, 2023
View reviewed changes
generators/app/templates/common/Makefile Outdated Show resolved Hide resolved
generators/app/templates/common/Makefile Outdated Show resolved Hide resolved
__tests__/app.js Outdated Show resolved Hide resolved
generators/app/templates/ci/.circleci/config.yml Outdated Show resolved Hide resolved
@jack-mcivor
Copy link
Contributor Author

@ywolff made those changes

ywolff
ywolff requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@ywolff ywolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some consistency issues, sorry if I was not clear in my previous comments!

generators/app/templates/ci/.azure-pipelines.yml Outdated Show resolved Hide resolved
generators/app/templates/ci/.circleci/config.yml Outdated Show resolved Hide resolved
generators/app/templates/ci/.circleci/config.yml Outdated Show resolved Hide resolved
generators/app/templates/ci/.github/workflows/tests.yml Outdated Show resolved Hide resolved
generators/app/templates/ci/.gitlab-ci.yml Outdated Show resolved Hide resolved
generators/app/templates/ci/.gitlab-ci.yml Outdated Show resolved Hide resolved
generators/app/templates/common/.pre-commit-config.yaml Outdated Show resolved Hide resolved
@jack-mcivor
Copy link
Contributor Author

Made those changes

@ywolff ywolff merged commit ba9c5e9 into sicara:main Nov 13, 2023
@ywolff
Copy link
Collaborator

ywolff commented Nov 13, 2023

Thanks @jack-mcivor!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ywolff ywolff ywolff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-mcivor @ywolff