Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add consistency between prettier and eslint #255

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PaulRosset
Copy link

…lint

Description

I've add a prettier.config.js file to be sure that everyone is using the same config to apply prettier on the project.
I also added a comma-dangle property on eslint.

We also had a problem on a eslint property concerning the camelcase, so I disabled the 2 lines concerned, because it depends on the ci-env packages. So, we need to edit it first.

Motivation and Context

The yarn lint script was not working correctly.
I also wanted to add comma-dangle to improve the readability of future pull request.

This PR is closely related to the issue #246

Types of changes

Chore

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I created an issue for the Pull Request

@PaulRosset PaulRosset force-pushed the feat/chore-prettier-eslint branch from 8086ca8 to 820dd82 Compare October 6, 2018 19:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant