Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: build should return noop on non-ci environments #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: build should return noop on non-ci environments #291

wants to merge 1 commit into from

Conversation

vigneshshanmugam
Copy link

@vigneshshanmugam vigneshshanmugam commented Mar 26, 2019 •
edited
Loading

Description

  • On non ci envrionements like running on local machine, bundlesize should not try to update non existing Github build statuses even though the token env is set.

Motivation and Context

  • export BUNDLESIZE_GITHUB_TOKEN="blah"
  • npm run bundlesize
 ERROR  Could not add github status.
      404: Not Found

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@vigneshshanmugam vigneshshanmugam mentioned this pull request Mar 26, 2019
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vigneshshanmugam