-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make brotli optional #320
Make brotli optional #320
Conversation
Open questions
|
I guess it depends how many things we want to change still in a v1, I think it's a breaking change as well |
True, might make sense to keep them all in a branch and release together. |
@siddharthkp You are making bundlesize plugable? if so, its just AWESOME Plugins are the kind of best suites for Scalability. |
Merged into beta channel |
It also looks like brotli size has been updated to drop Is there a roadmap for release of your beta? |
Hi! You might want to use this version of bundlesize that solves this issue: https://github.com/siddharthkp/bundlesize2#migration-from-bundlesize0180 it's not feature complete, but you might not need the missing features at all. |
Motivation and Context
From the looks of it,
iltorb
's native bindings are large + don't play well on all platforms - and fails installs on windows and some CI environments.bundlesize-plugin-brotli
to continueChanges introduced in this PR:
Remove
brotli-size
from dependenciesOn Node >= 10.6.0, use
zlib.brotliCompressSync
On Node < 10.6.0, ask to install
bundlesize-plugin-brotli
Introduces
bundlesize-plugin-brotli
Fixes #202, #283 and #213
Prior work: #220 #299