refactor: implement volume mount controller #10062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/mount-controller
branch
2 times, most recently
from
cf9f600 to
0e5b013
Compare
smira
force-pushed
the
feat/mount-controller
branch
3 times, most recently
from
926253e to
ec65b58
Compare
|
This PR implements only the first part of the volume mount flow, but I would like to split up things a bit to make it easier to get other changes in. The image cache config controller never did proper unmount of the volumes, so the same state here for now - we don't actually unmount anything, but simply using new controller to mount image cache volumes. The follow-up PR is planned to support first mounting STATE & EPHEMERAL, and that will include proper refactoring of the volume subsystem to support full unmount flow. |
smira
force-pushed
the
feat/mount-controller
branch
from
ec65b58 to
e530e41
Compare
smira
force-pushed
the
feat/mount-controller
branch
2 times, most recently
from
c93c481 to
312556d
Compare
frezbo
reviewed
Feb 10, 2025
frezbo
reviewed
Feb 10, 2025
frezbo
approved these changes
Feb 10, 2025
dsseng
approved these changes
Feb 10, 2025
|
|
||
| // RemountReadWrite remounts the mount point as read-write. | ||
| func (p *Point) RemountReadWrite() error { | ||
| p.flags &^= unix.MS_RDONLY |
There was a problem hiding this comment.
Is this equivalent to &= ~unix.MS_RDONLY?
There was a problem hiding this comment.
I think that should be exactly it.
smira
force-pushed
the
feat/mount-controller
branch
from
312556d to
060059a
Compare
Fixes siderolabs#9602 Aggregate incoming volume mount requests, reconcile them with volume status, perform actual mounting, and produce mount status. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
feat/mount-controller
branch
from
060059a to
5dbf9e3
Compare
|
/m |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9602
Aggregate incoming volume mount requests, reconcile them with volume status, perform actual mounting, and produce mount status.