feat: multiple docker clusters #8412
Conversation
|
Nit: for this repo, please create a PR from your fork (vs. pushing a branch to this repo). |
| @@ -85,11 +85,11 @@ func (p *provisioner) GetLoadBalancers(networkReq provision.NetworkRequest) (int | |||
| case "darwin", "windows": | |||
| return "", "127.0.0.1" | |||
There was a problem hiding this comment.
I guess we'd want all of the platforms to return this actually?
There was a problem hiding this comment.
Unsure, why pollute local ports (also exposing them on 0.0.0.0) without a reason when we can just access those by IP. However a CLI option could by good (if it doesn't pollute opts)
There was a problem hiding this comment.
We should probably expose only on the localhost, and making things work same way across platforms makes it easier to test it. We don't have tests running on !Linux, so we won't be testing this code if we don't make it act same way.
While on non-WSL Linux we can directly access containers' network, enable forwarding for the purpose of testing Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
example command to test: _out/talosctl-linux-amd64 cluster create --provisioner=docker --controlplanes 1 --workers 1 --image=127.0.0.1:5005/siderolabs/talos:v1.7.0-alpha.0-69-g1bb6027cc --control-plane-port 7444 Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
Fixes running in Docker with --control-plane-port Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
Almost ready for random ports Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
please re-create it from the fork, thanks! |
|
/ok-to-test |
dsseng
force-pushed
the
multiple-docker-clusters
branch
from
d388892 to
68796b8
Compare
Alright, will do now. Currently docker cluster startup fails for some reason, troubleshooting |
Pull Request
What? (description)
Making talosctl capable of creating multiple Docker clusters in case port forwarding is being used (Docker Desktop or WSL). Currently WIP
Why? (reasoning)
Fixes #8141
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)