Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add correct Types for PromisePoolCluster #2035

Closed

Conversation

adam-farhi
Copy link

fix for #1991

@JacobBanghart
Copy link

Following up here based on the linked ticket. In /lib/pool_cluster.js the return of PoolCluster.of is this._namespaces[key] which is a class PoolNameSpace. PoolNameSpace should be what is returned in a .of but instead it returns a PoolCluster. A Promise-based version of this does not solve this issue you can see by cloning the repo linked in the ticket and installing your fork locally.

@JacobBanghart
Copy link

#2036 Adjusts it in the manner that I was describing. Sorry for leaving the issue out there and not getting back to it life gets hecktic.

@wellwelwel
Copy link
Collaborator

Closing in favor of #2084.

@wellwelwel wellwelwel closed this Jun 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants