Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Theme names from ix are not compatible with ix-echart theme names #1106

Open
2 tasks done
caneserr opened this issue Feb 21, 2024 · 1 comment
Open
2 tasks done

Theme names from ix are not compatible with ix-echart theme names #1106

caneserr opened this issue Feb 21, 2024 · 1 comment
Labels
type: enhancement New feature or request Workflow: Issue created JIRA issue is created and will be analyzed

Comments

@caneserr
Copy link

caneserr commented Feb 21, 2024

Prerequisites

  • I have not leaked any internal company information.
  • I have not posted internal links or code snippets.

What happened?

themeSwitcher.getCurrentTheme() method returns ix themes formatted like this. "theme-brand-dark"
but ix-chart names are "brand-dark" , "brand-light" etc. OFC I can use string replace method like below but I cant always count on it in future.
themeSwitcher.getCurrentTheme().replace("theme-","")

Therefore the names of the themes of ix and echarts should be same.

What type of frontend frameware are you seeing the problem on?

React

Which version of iX do you use?

v.2.0.4

Code to produce this issue.

themeSwitcher.getCurrentTheme()
@caneserr caneserr added the triage We discuss this topic in our internal weekly label Feb 21, 2024
@matthiashader matthiashader added type: enhancement New feature or request Workflow: Issue created JIRA issue is created and will be analyzed and removed triage We discuss this topic in our internal weekly labels Feb 27, 2024
@matthiashader
Copy link
Collaborator

Thank you for your input. We will discuss this requirement internally! Internal ref [IX-955]

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: enhancement New feature or request Workflow: Issue created JIRA issue is created and will be analyzed
Projects
None yet
Development

No branches or pull requests

2 participants