Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(echarts): adapt theme names #1630

Open
wants to merge 4 commits into
base: release-3.0.0
Choose a base branch
from

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Dec 19, 2024

💡 What is the current behavior?

GitHub Issue Number: Closes #1106, [IX-955]

  • The echarts theme names deviate from the default theme names

🆕 What is the new behavior?

  • The echarts theme names now match the default theme names

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@jul-lam jul-lam self-assigned this Dec 19, 2024
Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: e267016

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix-echarts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant