Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

V3 remove bootstrap #1578

Draft
wants to merge 13 commits into
base: release-3.0.0
Choose a base branch
from
Draft

V3 remove bootstrap #1578

wants to merge 13 commits into from

Conversation

danielleroux
Copy link
Collaborator

🆕 What is the new behavior?

Remove bootstrap dependencies
To do:

  • Clarify H1 - Hx sizes
  • other stuff??

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 1275392

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@danielleroux danielleroux marked this pull request as draft November 26, 2024 11:07
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Report of strict check

src/tests/toggle-button/toggle-button.e2e.ts
  • src/tests/toggle-button/toggle-button.e2e.ts(28,11): error TS18047: 'b.shadowRoot' is possibly 'null'.: error TS18047: 'b.shadowRoot' is possibly 'null'.
  • src/tests/toggle-button/toggle-button.e2e.ts(28,11): error TS18047: 'b.shadowRoot' is possibly 'null'.: error TS18047: 'b.shadowRoot' is possibly 'null'.
  • src/tests/toggle-button/toggle-button.e2e.ts(28,11): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/tests/toggle-button/toggle-button.e2e.ts(28,11): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/tests/toggle-button/toggle-button.e2e.ts(46,11): error TS18047: 'b.shadowRoot' is possibly 'null'.: error TS18047: 'b.shadowRoot' is possibly 'null'.
  • src/tests/toggle-button/toggle-button.e2e.ts(46,11): error TS18047: 'b.shadowRoot' is possibly 'null'.: error TS18047: 'b.shadowRoot' is possibly 'null'.
  • src/tests/toggle-button/toggle-button.e2e.ts(46,11): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/tests/toggle-button/toggle-button.e2e.ts(46,11): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.

@danielleroux danielleroux changed the base branch from main to release-3.0.0 January 14, 2025 07:59
Copy link

@siemens siemens deleted a comment from sonarqubecloud bot Jan 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant