-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(core/information-bar): add information bar #637
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do's
- Add SPDX Header to new files if not present
/*
* SPDX-FileCopyrightText: 2023 Siemens AG
*
* SPDX-License-Identifier: MIT
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
- Add TestApp Examples (Angular/React/Vue)
- Add Documentation page
Notice:
TestApp and Documentation can be implemented afterwards from the core team
packages/core/src/components/information-bar/information-bar.tsx
Outdated
Show resolved
Hide resolved
@marci1501 will you be able to add the missing headers? The iX team will then take care of the other open points. |
Headers should already be there. |
You are right - my bad :-/ |
Remaining tasks tracked via [IX-643] |
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the new behavior?
Add "Information Bar" (Already discussed with @danielleroux)
Does this introduce a breaking change?