Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(core/information-bar): add information bar #637

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

marci1501
Copy link

@marci1501 marci1501 commented Jul 18, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Add "Information Bar" (Already discussed with @danielleroux)

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux changed the title Feat/information bar feat(core/information-bar): add information bar Jul 18, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jul 18, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Jul 18, 2023
@danielleroux danielleroux self-assigned this Jul 18, 2023
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do's

  • Add SPDX Header to new files if not present
/*
 * SPDX-FileCopyrightText: 2023 Siemens AG
 *
 * SPDX-License-Identifier: MIT
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */
  • Add TestApp Examples (Angular/React/Vue)
  • Add Documentation page

Notice:
TestApp and Documentation can be implemented afterwards from the core team

@danielleroux danielleroux removed this from the 2.0.0 milestone Sep 25, 2023
@nuke-ellington
Copy link
Collaborator

To do's

  • Add SPDX Header to new files if not present
/*
 * SPDX-FileCopyrightText: 2023 Siemens AG
 *
 * SPDX-License-Identifier: MIT
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */
  • Add TestApp Examples (Angular/React/Vue)
  • Add Documentation page

Notice: TestApp and Documentation can be implemented afterwards from the core team

@marci1501 will you be able to add the missing headers? The iX team will then take care of the other open points.

@marci1501
Copy link
Author

To do's

  • Add SPDX Header to new files if not present
/*
 * SPDX-FileCopyrightText: 2023 Siemens AG
 *
 * SPDX-License-Identifier: MIT
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */
  • Add TestApp Examples (Angular/React/Vue)
  • Add Documentation page

Notice: TestApp and Documentation can be implemented afterwards from the core team

@marci1501 will you be able to add the missing headers? The iX team will then take care of the other open points.

Headers should already be there.

@nuke-ellington
Copy link
Collaborator

To do's

  • Add SPDX Header to new files if not present
/*
 * SPDX-FileCopyrightText: 2023 Siemens AG
 *
 * SPDX-License-Identifier: MIT
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */
  • Add TestApp Examples (Angular/React/Vue)
  • Add Documentation page

Notice: TestApp and Documentation can be implemented afterwards from the core team

@marci1501 will you be able to add the missing headers? The iX team will then take care of the other open points.

Headers should already be there.

You are right - my bad :-/

@nuke-ellington
Copy link
Collaborator

To do's

  • Add SPDX Header to new files if not present
/*
 * SPDX-FileCopyrightText: 2023 Siemens AG
 *
 * SPDX-License-Identifier: MIT
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */
  • Add TestApp Examples (Angular/React/Vue)
  • Add Documentation page

Notice: TestApp and Documentation can be implemented afterwards from the core team

Remaining tasks tracked via [IX-643]

@nuke-ellington nuke-ellington marked this pull request as draft December 6, 2023 15:03
@danielleroux danielleroux added this to the 2.2.0 milestone Jan 8, 2024
@nuke-ellington nuke-ellington removed this from the 2.2.0 milestone Apr 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants