Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(www): preliminary support for uploading to the shared storage #426

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

chombourger
Copy link
Collaborator

No description provided.

Copy link
Member

@fmoessbauer fmoessbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks quite good (and I love to see that feature). I'm just wondering what happens if the upload is interrupted or gets stuck. Does this end-up in a non-recoverable situation as the storage remains open?

default:
storage_status.innerHTML = "unknown_document"
storage_status.title = "storage status unknown"
}
});
const CHUNK_SIZE = 512 * 1024;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the unit? Bytes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes bytes. I need to test this feature a little more and in particular with large images. May even need to throttle the upload a bit as the browser will probably read the image much faster than we can write it. I have entered new territory while trying to implement this feature

@chombourger chombourger removed the check label Oct 7, 2024
@chombourger
Copy link
Collaborator Author

In general this looks quite good (and I love to see that feature). I'm just wondering what happens if the upload is interrupted or gets stuck. Does this end-up in a non-recoverable situation as the storage remains open?

Reworked a session handling code a bit and will now close the shared storage device if the owning session has vanished

Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
Do not leave the shared storage device opened if the owning session
has not interacted with us before the session timeout expired.

Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
@chombourger chombourger added check and removed check labels Dec 29, 2024
@chombourger chombourger merged commit 07c23f4 into siemens:master Dec 30, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants