-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(www): preliminary support for uploading to the shared storage #426
Conversation
1bd8a06
to
233f015
Compare
233f015
to
21f8154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks quite good (and I love to see that feature). I'm just wondering what happens if the upload is interrupted or gets stuck. Does this end-up in a non-recoverable situation as the storage remains open?
default: | ||
storage_status.innerHTML = "unknown_document" | ||
storage_status.title = "storage status unknown" | ||
} | ||
}); | ||
const CHUNK_SIZE = 512 * 1024; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the unit? Bytes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes bytes. I need to test this feature a little more and in particular with large images. May even need to throttle the upload a bit as the browser will probably read the image much faster than we can write it. I have entered new territory while trying to implement this feature
Reworked a session handling code a bit and will now close the shared storage device if the owning session has vanished |
e8fca6d
to
825aa68
Compare
825aa68
to
8d23c47
Compare
8d23c47
to
9c77d05
Compare
9c77d05
to
deb051c
Compare
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
Do not leave the shared storage device opened if the owning session has not interacted with us before the session timeout expired. Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
deb051c
to
c2ee066
Compare
No description provided.